luca0N/lanbassador
luca0N/lanbassador
1
1
Fork 0
Code Issues 24 Pull requests 1 Projects 1 Releases 1 Packages Wiki Activity Actions

Update live connection handshake structure #70

Merged
luca0N merged 2 commits from dev_client_live_handshake into dev 2026-05-07 23:58:37 +00:00
Conversation 2 Commits 2 Files changed 1 +155 -43
luca0N commented 2026-05-07 23:07:21 +00:00
Owner
Copy link

Introduce required live connection flow changes imposed by the changes
made to the server code in commits
e6353ca48a and
b7f7f1dbf0, and refactor the serial packet
request flow by keeping track of the current operation with an enum
named `LiveStage'.

Introduce required live connection flow changes imposed by the changes made to the server code in commits e6353ca48a94be7dff652ca7b8002b19b07d773c and b7f7f1dbf0940ccfbf00a310f1425052b28c515e, and refactor the serial packet request flow by keeping track of the current operation with an enum named `LiveStage'.
Introduce required live connection flow changes imposed by the changes
made to the server code in commits
e6353ca48a and
b7f7f1dbf0, and refactor the serial packet
request flow by keeping track of the current operation with an enum
named `LiveStage'.
luca0N force-pushed dev_client_live_handshake from 5cb6da924c to ee97e0de5c 2026-05-07 23:11:40 +00:00 Compare
luca0N commented 2026-05-07 23:11:56 +00:00
Author
Owner
Copy link

Latest force-push removes an unused import and class variable.

Latest force-push removes an unused import and class variable.
luca0N force-pushed dev_client_live_handshake from ee97e0de5c to 2a39e1f14c 2026-05-07 23:12:37 +00:00 Compare
luca0N reviewed 2026-05-07 23:17:19 +00:00
luca0N left a comment
Copy link

Some minor things to enhance the code quality before merging this pull request.

Some minor things to enhance the code quality before merging this pull request.
client/src/app/LiveConnection.ts Outdated
@ -55,3 +61,2 @@
version: string;
action: string;
data: string | undefined;
data: any;
luca0N commented 2026-05-07 23:13:44 +00:00
Author
Owner
Copy link

I would like for data to actually refer to a generic type T for higher flexibility. Although any is as permissive as it gets, we'd lack standard TypeScript safeguards.

I would like for `data` to actually refer to a generic type `T` for higher flexibility. Although `any` is as permissive as it gets, we'd lack standard TypeScript safeguards.
luca0N commented 2026-05-07 23:36:54 +00:00
Author
Owner
Copy link

This will be done outside this pull request.

This will be done outside this pull request.
client/src/app/LiveConnection.ts Outdated
@ -93,18 +97,27 @@ interface LiveConnectionData {
port: number;
}
enum LiveStage {
luca0N commented 2026-05-07 23:14:22 +00:00
Author
Owner
Copy link

Some inline documentation would do some good here.

Some inline documentation would do some good here.
luca0N marked this conversation as resolved
client/src/app/LiveConnection.ts Outdated
@ -142,0 +162,4 @@
let packetData = undefined;
switch (this.liveStage) {
case LiveStage.LIVE_STAGE_CLIENT_ACTION_HELLO:
packetAction = "HELLO";
luca0N commented 2026-05-07 23:15:31 +00:00
Author
Owner
Copy link

These strings should likely be in the form of consts, or as part of an enum which can be converted to strings as necessary. Having these values hardcoded throughout the code is prone to errors.

These strings should likely be in the form of `const`s, or as part of an enum which can be converted to strings as necessary. Having these values hardcoded throughout the code is prone to errors.
luca0N marked this conversation as resolved
client/src/app/LiveConnection.ts Outdated
@ -142,0 +180,4 @@
if (packetData !== undefined)
packet.data = packetData;
this.ws?.send(JSON.stringify(packet));
luca0N commented 2026-05-07 23:16:17 +00:00
Author
Owner
Copy link

An Error should be thrown if this.ws is null.

An `Error` should be thrown if `this.ws` is null.
luca0N marked this conversation as resolved 
Add missing documentation to the changes made to LiveConnection, and
perform minor code refactoring by moving hardcoded strings to a new
enum.

See previous commit for context on the changes made to LiveConnection.
luca0N deleted branch dev_client_live_handshake 2026-05-07 23:58:37 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Compat/Breaking
Breaking change that won't be backward compatible

  
Kind/Bug
Something is not working

  
Kind/Documentation
Documentation changes

  
Kind/Enhancement
Improve existing functionality

  
Kind/Feature
New functionality

  
Kind/Security
This is security issue

  
Kind/Testing
Issue or pull request related to testing

  
Priority
Critical
 The priority is critical

  
Priority
High
 The priority is high

  
Priority
Low
 The priority is low

  
Priority
Medium
 The priority is medium

  
Reviewed
Confirmed
 Issue has been confirmed

  
Reviewed
Duplicate
 This issue or pull request already exists

  
Reviewed
Invalid
 Invalid issue

  
Reviewed
Won't Fix
 This issue won't be fixed

  
Status
Abandoned
 Somebody has started to work on this but abandoned work

  
Status
Blocked
 Something is blocking this issue or pull request

  
Status
Need More Info
 Feedback is required to reproduce issue or to continue work

No labels
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Blocks
#67 Handle server live authentication inside WebSocket connection
luca0N/lanbassador
Depends on
#69 Enhance live connection handshake interpretation in server
luca0N/lanbassador
Reference
luca0N/lanbassador!70
No description provided.