Handle server live authentication inside WebSocket connection #67
Labels
No labels
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Depends on
#56 Refactor server WebSocket comms
luca0N/lanbassador
#69 Enhance live connection handshake interpretation in server
luca0N/lanbassador
#70 Update live connection handshake structure
luca0N/lanbassador
Reference
luca0N/lanbassador#67
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
The WebSocket API does not offer any functionality for specifying headers. As such, the current authentication check implemented in the live endpoint handler cannot be used in any browser.
The server should perform session validation after a WebSocket connection has been established.
Added #56 as a dependency, as otherwise the current code would be too long, complex, prone to errors and bugs, and would be quite lacking in code quality.
I am planning on refactoring WebSocket I/O operations, more specifically.
I am currently taking this rework as an opportunity to have an initial handshake instead of having the client send the protocol version in every single packet1.
// TODO: remove Version from the packet; there is no need to send this in↩︎