Add MariaDB to Docker Compose file (closes #81) #84
No reviewers
Labels
No labels
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Depends on
#85 Add server support for database *NIX sockets
luca0N/lanbassador
Reference
luca0N/lanbassador!84
Loading…
Reference in a new issue
No description provided.
Delete branch "dev_compose_db"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Add the MariaDB Docker image as a
servercontainer dependency in theproject Docker Compose file.
I have already validated these changes and I can confirm that they work flawlessly. I will refrain from merging this pull request at this time to mull over a potential security issue, which I will go into detail in the next comment.
@ -67,0 +97,4 @@MARIADB_RANDOM_ROOT_PASSWORD: 1MARIADB_DATABASE: lanbassadorMARIADB_USER: lanbassadorMARIADB_PASSWORD: lanbassadorUsing
lanbassadoras the database password is precisely why I wanted to use *NIX sockets (see #81).Although this is more secure and locks down database server access a bit further, I want to take some time to investigate about the security implications of this, because, even though a *NIX socket is being used, it can still be accessed in the host, depending on filesystem directory permissions.
An option would be to keep everything as is, and have the system administrator deal with hardening the server by changing the permissions of the directory on the host filesystem (e.g., mode
0700to root on./mariadb-run/). If this route were to be taken, then I have to make sure that this is crystal clear in this file by adding some comments about it.