luca0N/lanbassador
luca0N/lanbassador
1
1
Fork 0
Code Issues 15 Pull requests 1 Projects 1 Releases 1 Packages Wiki Activity Actions

Display error feedback to end user (fixes #12) #13

Merged
luca0N merged 3 commits from dev_error_feedback into dev 2025-11-18 15:43:58 +00:00
Conversation 0 Commits 3 Files changed 6 +78 -16
luca0N commented 2025-11-18 15:41:48 +00:00
Owner
Copy link

This pull request introduces two important changes:

  1. if an error occurs in the new thread in libknock2, a new callback is called to indicate that an unrecoverable error occurred (at this time, it is not used to indicate warnings or non-critical errors), and
  2. display an alert dialog that tells the end user that an error occurred while connecting to the Knock2 server.
This pull request introduces two important changes: 1. if an error occurs in the new thread in libknock2, a new callback is called to indicate that an unrecoverable error occurred (at this time, it is not used to indicate warnings or non-critical errors), and 2. display an alert dialog that tells the end user that an error occurred while connecting to the Knock<sup>2</sup> server.
luca0N self-assigned this 2025-11-18 15:41:48 +00:00 
Change return type of the analyze function in libknock2 from void to
int, so as to indicate whether the function succeeded (return code 0)
or not, and create a new callback function type for signaling errors
from the new thread.

The callback was created because otherwise it wouldn't be possible to
indicate that an error had occurred, since the capturing logic is
non-blocking.
In the Knock^2 server, listen for libknock2 errors and panic if an error
is signaled.
Display an alert dialog if a WebSocket error occurs, providing feedback
to the end user.
luca0N deleted branch dev_error_feedback 2025-11-18 15:43:58 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Compat/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

No labels
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
luca0N
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
luca0N/lanbassador!13
No description provided.