Fix the double onConnectionError event signal #49

New issue

Open

opened 2026-02-11 23:41:54 +00:00 by luca0N · 0 comments

luca0N commented

2026-02-11 23:41:54 +00:00

Owner

The onConnectionError event from the ServerConnection class may be signaled twice in a row. Commit aae71f9c1b introduces a mitigation for this by closing all opened dialogs, but this can be problematic if another important dialog is being displayed at the time this event is signaled.

At this time, the only other dialog that is used in the host list page is the preferences dialog. Changes made to that dialog are immediately effective, plus, there's only one option in it, so it wouldn't be too bad to be in a situation where that dialog would be closed by the server connection error event.

If more dialogs are added to that page in the future, this issue should be fixed first to avoid poor UX.

The `onConnectionError` event from the `ServerConnection` class may be signaled twice in a row. Commit aae71f9c1b16bcf2e915297ba515f56b82dd8b59 introduces a mitigation for this by closing _all_ opened dialogs, but this can be problematic if another important dialog is being displayed at the time this event is signaled. At this time, the only other dialog that is used in the host list page is the preferences dialog. Changes made to that dialog are immediately effective, plus, there's only one option in it, so it wouldn't be too bad to be in a situation where that dialog would be closed by the server connection error event. If more dialogs are added to that page in the future, this issue should be fixed first to avoid poor UX.